Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add third body shadow #532

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add third body shadow #532

merged 3 commits into from
Oct 31, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Oct 30, 2023

Related issues

#8

Description

I added the third shadow source calculation feature.

Test results

image

Impact

Minor update.

Supplementary information

NA

@200km 200km added priority::medium priority medium environment environment calculation minor update add functionality in a backwards compatible manner labels Oct 30, 2023
@200km 200km added this to the Minor update v7.1.0 milestone Oct 30, 2023
@200km 200km self-assigned this Oct 30, 2023
@200km 200km requested review from sksat and a team as code owners October 30, 2023 09:20
@200km 200km requested review from suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team October 30, 2023 09:20
@200km 200km linked an issue Oct 30, 2023 that may be closed by this pull request
Consider the eclipse effect by the moon and other planets #8
Closed
3 tasks
@200km 200km merged commit 98b69b7 into develop Oct 31, 2023
41 checks passed
@200km 200km deleted the feature/add-third-body-shadow branch October 31, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-toshihir0 suzuki-toshihir0 suzuki-toshihir0 approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma t-hosonuma is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@200km 200km

Labels
environment environment calculation minor update add functionality in a backwards compatible manner priority::medium priority medium
Projects
S2E
Archived in project
Milestone
Minor update v7.1.0
Development

Successfully merging this pull request may close these issues.

Consider the eclipse effect by the moon and other planets
2 participants
@200km @suzuki-toshihir0